-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Use const
and let
over var
#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for sussing out the inconsistencies. We do need a coherent stance on this. @ericelliott has a good article about this, to use as inspiration so we could also elaborate more on the ES6 constants section. |
I even just started to edit for a PR, but then there were so much changes to make ^^ I highly recommend this screencast from laracast: I personally don't use I could open a PR with my method, if the wish is there. |
@schoenwaldnils has an awesome fix so I'm going to close this issue once that is merged in with minor tweaks. Thanks CodinCat for your help! |
This was addressed in #51. Thanks for all of your help! |
The current code samples are not consistent, mix a half
var
and a halflet
(and a fewconst
).We may need a unified rule for the usage of
const
/let
and apply it to the code samples, as you mentioned in the second principle Use ES6 constants when variable values do not change, or your code is not clean. πThe text was updated successfully, but these errors were encountered: