Change var and let where necessary #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmcdermott
requested changes
Jan 7, 2017
| date.addDays(30); | ||
| date.shouldEqual('1/31/2015'); | ||
| }); | ||
|
|
||
| it('handles leap year', function() { | ||
| let date = new MakeMomentJSGreatAgain('2/1/2016'); | ||
| cosnt date = new MakeMomentJSGreatAgain('2/1/2016'); |
| date.addDays(28); | ||
| assert.equal('02/29/2016', date); | ||
| }); | ||
|
|
||
| it('handles non-leap year', function() { | ||
| let date = new MakeMomentJSGreatAgain('2/1/2015'); | ||
| cosnt date = new MakeMomentJSGreatAgain('2/1/2015'); |
This was referenced Jan 7, 2017
Closed
Merged
added 2 commits
January 7, 2017 15:06
* 'master' of github.com:ryanmcdermott/clean-code-javascript: Add: Error Handling Section Correct spelling of Cessna airplane Adjusted the commentthat show the result
|
This looks great! Since sadly the examples in this document aren't testable (maybe we could find a way in the future), I assume that everything here works after reading it as carefully as I could. If anyone sees anything else that stands out with these changes, open an issue or ideally a PR 😄 |
This was referenced Jan 8, 2017
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #31 here my implementation of
constandlet.