Feature/change var #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
reviewed
Jan 6, 2017
| @@ -102,8 +102,8 @@ for (var i = 0; i < 525600; i++) { | |||
| **Good**: | |||
| ```javascript | |||
| // Declare them as capitalized `var` globals. | |||
There was a problem hiding this comment.
Maybe '// Declare them as capitalized const globals.' as well.
This was referenced Jan 6, 2017
Closed
patcon
reviewed
Jan 7, 2017
| var MINUTES_IN_A_YEAR = 525600; | ||
| for (var i = 0; i < MINUTES_IN_A_YEAR; i++) { | ||
| // Declare them as capitalized `const` globals. | ||
| const MINUTES_IN_A_YEAR = 525600; |
There was a problem hiding this comment.
came into the issues wondering about the same thing ;)
|
Thanks so much at looking into this Valère! I appreciate your good insights. Keep up the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should update most of var in let.
I changed few var to const because i though it was more appropriate