Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix one code example use console.log to print error #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

othree
Copy link
Contributor

@othree othree commented Jan 10, 2017

Based on the Error Handling section.
I think good example should all use console.error to deal with error messages.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jan 10, 2017

It seems the line 1798 should be corrected as well. Let bad examples be fairly bad)

@othree
Copy link
Contributor Author

othree commented Jan 10, 2017

Line 1798 is bad example. Use console.log on purpose.

@vsemozhetbyt
Copy link
Contributor

Ah. sorry, I've misread this one.

@ryanmcdermott ryanmcdermott merged commit 8f7c8ce into ryanmcdermott:master Jan 10, 2017
@ryanmcdermott
Copy link
Owner

I love it!

@othree othree changed the title Fix one code exsample use console.log to print error Fix one code example use console.log to print error Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants