Rename state to zipCode to avoid confusion #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destructuring state using the regex was a little bit ambiguous since there is no state in the address (zip code instead).
| @@ -102,16 +102,17 @@ setTimeout(() => { | |||
| **Bad:** | |||
| ```javascript | |||
| const address = 'One Infinite Loop, Cupertino 95014'; | |||
| const cityStateRegex = /^[^,\\]+[,\\\s]+(.+?)\s*(\d{5})?$/; | |||
| const city | |||
| Regex = /^[^,\\]+[,\\\s]+(.+?)\s*(\d{5})?$/; | |||
There was a problem hiding this comment.
It seems to be erroneous line break here
|
@vsemozhetbyt My bad. Fixed it. |
| @@ -102,8 +102,7 @@ setTimeout(() => { | |||
| **Bad:** | |||
| ```javascript | |||
| const address = 'One Infinite Loop, Cupertino 95014'; | |||
| const city | |||
| Regex = /^[^,\\]+[,\\\s]+(.+?)\s*(\d{5})?$/; | |||
| const cityStateRegex = /^[^,\\]+[,\\\s]+(.+?)\s*(\d{5})?$/; | |||
There was a problem hiding this comment.
The name of the Bad regex and Good regex don't match. We should make them the same variable.
ryanmcdermott
requested changes
Jan 12, 2017
|
@ryanmcdermott Done! |
|
Woo hoo! Thank you Vasa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty minor. But destructuring state using the regex was a little bit ambiguous since there is no state in the address (zip code instead).