Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add translations section + fix minor typo md error #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2017

Conversation

felipe-augusto
Copy link
Contributor

Add translation section in the same format of AirBnb style, with Brazilian Portuguese and Chinese translations.

I"m unable to tell the difference between "Traditional" and "Simplified" Chinese as AirBnb did in their translations, perhaps someone can help with this distinction.

Also, fix a minor markdown error.

Add translation section same format AirBnb style, with Brazilian Portuguese and Chinese translations
@ryanmcdermott ryanmcdermott merged commit e075d8d into ryanmcdermott:master Jan 19, 2017
@ryanmcdermott
Copy link
Owner

Thank you so much for taking the time to put your translation together, and for this PR 🎉 Clean JavaScript for everyone!

@ryanmcdermott
Copy link
Owner

@fesnt Can you also include a link in your translation to this repository? Thank you!

@felipe-augusto
Copy link
Contributor Author

felipe-augusto commented Jan 19, 2017

Yes, do you have a preference in the format I should do this, and where?

Also, people are opening issues with suggestions in the Portuguese translation. Some are fixes, but others are suggestions, for example: don't use foreach, only map. Should I keep opening issues here with the observations and fixes made by this people?

@felipe-augusto
Copy link
Contributor Author

@ryanmcdermott, forgot to mark you on this, what are your thoughts on what I said before?

@ryanmcdermott
Copy link
Owner

I think we will start to diverge at a certain point if we don't keep connected on issues. Keep opening them here if you get different ones from this project! I don't have a preference for the link back to this repo! Anywhere you see fit, in any format. As long as there's a link 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants