Update README.md to include explanatory function names per #200 #206
Conversation
|
Thanks! My only suggestion is it might be just a tad clearer to have |
|
I personally agree, I was sticking to the issue discussion suggestions but this does make more sense. While typing it up I thought of `isActiveClientActive || isClientEmailActive' but was hesitant in getting too descriptive in making it so I think this is a nice happy medium :) |
README.md
Outdated
| clients | ||
| .filter(isClientActive) | ||
| .filter(isActive) |
There was a problem hiding this comment.
Can you change this to isActiveClient? Thanks!
There was a problem hiding this comment.
trying to stay active.... i amnot sure about everything here.. need my time
updating L278 to `isActiveClient`
|
Wait, did I miss something on this? The names are so similar it feels like I missed something haha |
|
Sorry for the delay! Thank you @rouzbeh84! |
|
No worries at all! I just kept seeing it and was hoping I didn't mess it up somehow haha. Great project! keep up the awesome work! |
updating function name per #200 thanks to @marzelin to clean up some issues