Fix semantic mistake #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original phrase "As stated in the Gang of Four..." is semantically incorrect. - The "Gang of Four" is a group of authors: Erich Gamma, Richard Helm, Ralph Johnson and John Vlissides. - They wrote a famous book: Design Patterns. - Here, Ryan McDermott is referring to the software-design principle "you should prefer composition over inheritance." - This principle was stated in the book, Design Patterns. - It was not stated in the Gang of Four -- the authors themselves.
|
True, it would be weird for it to be stated in the authors. Thanks for correcting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original phrase "As stated in the Gang of Four..." is semantically incorrect.