parenthesize arrow function arguments consistently #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmcdermott
requested changes
Jan 10, 2017
| @@ -373,7 +373,7 @@ code eligible for refactoring. | |||
| **Bad:** | |||
| ```javascript | |||
| function showDeveloperList(developers) { | |||
| developers.forEach(developers => { | |||
| developers.forEach((developers) => { | |||
There was a problem hiding this comment.
There was another PR about this that got lost in the fray, can we change this to developers.forEach((developer) =>
There was a problem hiding this comment.
Seems to be fixed in the second commit.
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Here comes a bunch of PRs after a code fragments mass test with ESLint checks and Node.js runnings.)