Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fill missing commas #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2017

Conversation

iamken1204
Copy link
Contributor

No description provided.

@Tarabass
Copy link
Contributor

I think you meant to say semicolons or semi-colons ;)

I have an other point of view. Remove them all when you don't need them (like in for loops).

Copy link
Contributor

@Tarabass Tarabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit info (and branch name) imply that you have added missing comma's. Instead semicolons are added.

On some rules semicolons are still missing:
222,
454,
474,
561,
2083,
2095

@iamken1204
Copy link
Contributor Author

Always confused with commas and semicolons :(
IMO semicolons are not necessary for javascript (except ;(function(){})();)

@ryanmcdermott
Copy link
Owner

Thanks for looking at this Kettan! Can you rebase this with master? I will merge in afterwards.

@ryanmcdermott ryanmcdermott merged commit 7ec1fe7 into ryanmcdermott:master Jan 13, 2017
@ryanmcdermott
Copy link
Owner

Thanks Kettan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants