Thanks to visit codestin.com
Credit goes to github.com

Skip to content

correct using of this in examples #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2017
Merged

correct using of this in examples #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 36 additions & 36 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,11 +741,11 @@ class Airplane {
getCruisingAltitude() {
switch (this.type) {
case '777':
return getMaxAltitude() - getPassengerCount();
return this.getMaxAltitude() - this.getPassengerCount();
case 'Air Force One':
return getMaxAltitude();
return this.getMaxAltitude();
case 'Cessna':
return getMaxAltitude() - getFuelExpenditure();
return this.getMaxAltitude() - this.getFuelExpenditure();
}
}
}
Expand All @@ -760,21 +760,21 @@ class Airplane {
class Boeing777 extends Airplane {
// ...
getCruisingAltitude() {
return getMaxAltitude() - getPassengerCount();
return this.getMaxAltitude() - this.getPassengerCount();
}
}

class AirForceOne extends Airplane {
// ...
getCruisingAltitude() {
return getMaxAltitude();
return this.getMaxAltitude();
}
}

class Cessna extends Airplane {
// ...
getCruisingAltitude() {
return getMaxAltitude() - getFuelExpenditure();
return this.getMaxAltitude() - this.getFuelExpenditure();
}
}
```
Expand Down Expand Up @@ -1006,12 +1006,12 @@ class UserSettings {
}

changeSettings(settings) {
if (this.verifyCredentials(user)) {
if (this.verifyCredentials()) {
// ...
}
}

verifyCredentials(user) {
verifyCredentials() {
// ...
}
}
Expand Down Expand Up @@ -1406,35 +1406,35 @@ classes until you find yourself needing larger and more complex objects.
**Bad:**
```javascript
const Animal = function(age) {
if (!(this instanceof Animal)) {
throw new Error("Instantiate Animal with `new`");
}
if (!(this instanceof Animal)) {
throw new Error("Instantiate Animal with `new`");
}

this.age = age;
this.age = age;
};

Animal.prototype.move = function() {};

const Mammal = function(age, furColor) {
if (!(this instanceof Mammal)) {
throw new Error("Instantiate Mammal with `new`");
}
if (!(this instanceof Mammal)) {
throw new Error("Instantiate Mammal with `new`");
}

Animal.call(this, age);
this.furColor = furColor;
Animal.call(this, age);
this.furColor = furColor;
};

Mammal.prototype = Object.create(Animal.prototype);
Mammal.prototype.constructor = Mammal;
Mammal.prototype.liveBirth = function() {};

const Human = function(age, furColor, languageSpoken) {
if (!(this instanceof Human)) {
throw new Error("Instantiate Human with `new`");
}
if (!(this instanceof Human)) {
throw new Error("Instantiate Human with `new`");
}

Mammal.call(this, age, furColor);
this.languageSpoken = languageSpoken;
Mammal.call(this, age, furColor);
this.languageSpoken = languageSpoken;
};

Human.prototype = Object.create(Mammal.prototype);
Expand All @@ -1445,29 +1445,29 @@ Human.prototype.speak = function() {};
**Good:**
```javascript
class Animal {
constructor(age) {
this.age = age;
}
constructor(age) {
this.age = age;
}

move() {}
move() { /* ... */ }
}

class Mammal extends Animal {
constructor(age, furColor) {
super(age);
this.furColor = furColor;
}
constructor(age, furColor) {
super(age);
this.furColor = furColor;
}

liveBirth() {}
liveBirth() { /* ... */ }
}

class Human extends Mammal {
constructor(age, furColor, languageSpoken) {
super(age, furColor);
this.languageSpoken = languageSpoken;
}
constructor(age, furColor, languageSpoken) {
super(age, furColor);
this.languageSpoken = languageSpoken;
}

speak() {}
speak() { /* ... */ }
}
```
**[⬆ back to top](#table-of-contents)**
Expand Down