Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ensure first argument on strpos is a string#1385

Merged
phil-davis merged 1 commit into
masterfrom
fix/tree-mark-dirty-strpos-int
Jan 20, 2022
Merged

fix: ensure first argument on strpos is a string#1385
phil-davis merged 1 commit into
masterfrom
fix/tree-mark-dirty-strpos-int

Conversation

@DeepDiver1975
Copy link
Copy Markdown
Member

@DeepDiver1975 DeepDiver1975 commented Jan 20, 2022

No description provided.

@DeepDiver1975 DeepDiver1975 linked an issue Jan 20, 2022 that may be closed by this pull request
Exception: strpos() expects parameter 1 to be string, int given #1384
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #1385 (fec8f14) into master (1f9bfa7) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1385      +/-   ##
============================================
- Coverage     97.38%   97.19%   -0.19%     
  Complexity     2826     2826              
============================================
  Files           175      175              
  Lines          8021     8352     +331     
============================================
+ Hits           7811     8118     +307     
- Misses          210      234      +24
Impacted Files Coverage Δ
lib/DAV/Tree.php 100.00% <100.00%> (ø)
lib/DAV/Xml/Element/Response.php 96.00% <0.00%> (-4.00%) ⬇️
lib/CalDAV/ICSExportPlugin.php 97.22% <0.00%> (-1.36%) ⬇️
lib/DAVACL/Xml/Property/SupportedPrivilegeSet.php 95.23% <0.00%> (-1.32%) ⬇️
lib/DAVACL/Plugin.php 94.11% <0.00%> (-1.17%) ⬇️
lib/CalDAV/SharingPlugin.php 98.38% <0.00%> (-0.74%) ⬇️
lib/DAV/Server.php 96.62% <0.00%> (-0.58%) ⬇️
lib/CalDAV/Plugin.php 97.77% <0.00%> (-0.41%) ⬇️
lib/CardDAV/Plugin.php 96.70% <0.00%> (-0.22%) ⬇️
lib/DAV/Sync/Plugin.php 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9bfa7...fec8f14. Read the comment docs.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/tree-mark-dirty-strpos-int branch from e058c6b to fec8f14 Compare January 20, 2022 12:00
@phil-davis phil-davis mentioned this pull request Jan 20, 2022
Closed
@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Jan 20, 2022

owncloud/core#39702
PR owncloud/core#39703 has acceptance tests that demonstrate the problem.
Made the same edit as here, to sabre/dav/lib/DAV/Tree.php locally in my ownCloud dev installation, and reran the failing acceptance test and it passes.

phil-davis
phil-davis approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis requested a review from staabm January 20, 2022 13:39
@phil-davis phil-davis merged commit 53e4229 into master Jan 20, 2022
@phil-davis phil-davis deleted the fix/tree-mark-dirty-strpos-int branch January 20, 2022 13:51
@brandonj35578 brandonj35578 mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staabm staabm staabm approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception: strpos() expects parameter 1 to be string, int given

3 participants

@DeepDiver1975 @phil-davis @staabm