Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding basic modules including python and cython code + setup file + etc. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seblabbe
Copy link
Collaborator

No description provided.

@nthiery
Copy link
Collaborator

nthiery commented May 4, 2017

Anyone objections on merging this branch in, to include an example of how to handle Cython code?
Sébastien: shall we take 5 minutes tomorrow to do it together?

@mmasdeu
Copy link

mmasdeu commented Jul 21, 2017

Should we close this PR? It seems that all the changes it incorporates are already present in the @mkoeppe 's branch.

@seblabbe
Copy link
Collaborator Author

I am currently at Sage Days 117. There was a demo earlier this week on how to share code and create a package where we used sage_sample. I am now taking a look at all the PR that have been here for years now...

No discussion has never been made about who should merge PRs.

The current PR has conflicts. I let the author or someone else fix them.

@mkoeppe
Copy link

mkoeppe commented Feb 10, 2023

I think we should get rid of sage_sample and instead point people to real projects that follow best practices.

@videlec
Copy link
Collaborator

videlec commented Feb 10, 2023

I second Matthias. All this is very outdated.

@seblabbe
Copy link
Collaborator Author

Ok, personally, I don't know because I did not follow the evolution of the practices since many years. Do you have a list of real projects that follow best practices in mind?

@nthiery
Copy link
Collaborator

nthiery commented Feb 12, 2023

Yeah, the current version of sage_sample is most likely quite outdated indeed.

I still believe that there is value in having an easy to find minimal example that people
can copy from to get started. A reasonable option would be to wipe this one and
recreate it from scratch using the current best practices. Alas I can't volunteer
(and would not have the required recent expertise anyway).

It could be a cookie cutter instead.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants