Perf/rearchitecture - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app had become painfully slow and laggy on the iPhone. I measured on a real device before changing anything. The root cause: the app was doing heavy database work while drawing the screen, over and over. Every time a screen refreshed, it re-ran an expensive ~230ms calculation that loaded the entire history of health data into memory and screens refresh hundreds of times during normal use and syncing.
This branch restructures how the app loads and shows data, following standard iOS practice:
Results
Screens that used to lock up are now responsive, including during sync.
Related issues
Type of change
How was this tested?
This was tested on iPhone 16 Pro.
PulseLoopTests)⌘Uin Xcode)-seedDemo YES, no hardware)Privacy & data
Screenshots / recordings
Checklist