fix(ui): coach summary owns the top card and no longer duplicates on Today - #42
Merged
Merged
Conversation
…Today On the Today tab the coach summary rendered twice — the top HeroInsightCardView and a bottom CoachMessageCard both derive from TodayInsights.deriveHero, so whenever the coach summary fell back to the hero text (coach off, or the summary call failed) both cards showed the same content. - Today: the coach now owns the single top card (tap → chat) when enabled; the deterministic hero fills that slot only when the coach is off. The duplicate bottom card is removed. - Sleep: the coach card moves to the top, in line with Today. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
saksham2001
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the Today tab the coach summary rendered twice: the top
HeroInsightCardViewand a bottom
CoachMessageCardboth derive fromTodayInsights.deriveHero, sowhenever the coach summary fell back to the hero text (coach off, or the summary
call failed) both cards showed the same "Steady build" content.
the deterministic hero fills that slot only when the coach is off. The
duplicate bottom card is removed.
Related issues
N/A
Type of change
How was this tested?
Privacy & data
Checklist