feat(pairing): add Colmi R08 ring support - #71
Merged
Merged
Conversation
The R08 was the one gap in the Colmi lineup (R02/R03/R06/R07/R09/R10/R11/R12 were all present). Add it as a colmiFamily entry (family .colmiR02, so it routes through the existing ColmiDriver + full Colmi capability set) plus the product image asset. No protocol work needed: the whole Colmi/Yawell family shares one protocol, and ColmiCoordinator.matches already recognizes a ring by the Colmi service UUID as well as the name map — so an R08 connects and syncs on the existing driver. This entry gives it a proper 'Colmi R08' identity + product art in the pairing carousel and device card. Advertised-name pattern '^R08_.*' follows the R06/R09 convention; if a physical R08 advertises differently it's a one-line regex tweak (and recognition still falls back to the service UUID regardless). Not tested on hardware — no R08 available.
saksham2001
approved these changes
Jul 10, 2026
Owner
|
Hi, that works! ThanksEnvoyé de mon iPadLe 21 juil. 2026 à 02:05, Saksham Bhutani ***@***.***> a écrit :saksham2001 left a comment (saksham2001/PulseLoopiOS#71)
I cant pair my colmi r08 with the app. I see it in qring after I remove it. But not in PulseLoop. Look at the capture.
Can you un-pair from QRing, then go to iOS settings and forget the ring? Then reopen PulseLoop and then try to connect to the ring. If you don't forget in iOS settings it doesn't show up for the app.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What
Adds the Colmi R08 to the ring catalog — it was the one gap in the Colmi lineup (R02/R03/R06/R07/R09/R10/R11/R12 were already present). Adds a
colmiFamilycatalog entry + the product image asset (colmi-r08).Why it's just a catalog entry
The whole Colmi/Yawell ring family shares one protocol/driver (
family: .colmiR02→ColmiDriver), andColmiCoordinator.matchesrecognizes a ring by the Colmi service UUID as well as the name map. So an R08 already connects and syncs on the existing driver + full Colmi capability set — no protocol/decoder work needed. This entry gives it a proper "Colmi R08" identity and product art in the pairing carousel + device card (instead of appearing as a generic ring).Notes
^R08_.*follows the R06/R09 convention. If a physical R08 advertises under a different local name (Colmi is inconsistent — e.g. R07 isCOLMI R07_…, R11 isR11C_…), it's a one-line regex change — and recognition still falls back to the service UUID regardless, so pairing works either way.