Protocol parity with the JRing app fixes - #77
Merged
Merged
Conversation
Closed
2 tasks
Adds 0x23 mode 1 (BP) as an explicit spot measurement, a .manualBloodPressure capability, a Measure BP action, and a calibration flow that takes a fresh ring reading before deriving the display offset. SpO2's move to 0x23 mode 2 had otherwise left nothing sending the BP mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PulseLoop's 56ff driver was reverse-engineered from partial knowledge. Decompiling the vendor JRing Android app (SDK com.sxr.sdk.ble.keepfit, app com.jaga.ibraceletplus.jyring) let us diff our driver against ground truth. Three long-standing user reports all trace to verified divergences, and the diff surfaced two outright bugs.
What changed
Related issues
This should fix #8 and #14
Type of change
How was this tested?
Need testing with 56ff ring.
PulseLoopTests)⌘Uin Xcode)-seedDemo YES, no hardware)Privacy & data
Checklist