Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sitemap.xml からダウンロードページ削除 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

beckorz
Copy link

@beckorz beckorz commented Apr 29, 2020

古いダウンロードページ(old_download.html)をsitemap.xmlから削除して検索サイトの検索インデックスから除外します。現状old_download.htmlは過去情報参照用にリポジトリ上からは削除しません。

KENCHjp
KENCHjp previously approved these changes Apr 29, 2020
Copy link
Member

@KENCHjp KENCHjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正あざます。

dsk_sakura.css Outdated
@@ -1,6 +1,6 @@
body
{
font-family: "Verdana", "Arial", "Helvetica", "MS Pゴシック", sans-serif;
font-family: "Verdana", "Arial", "Helvetica", "Meiryo", "メイリオ", sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは意図して変えてますか?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいこと言うと、変えるなら 別 PR とすべきかと思います。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません。同意です。こちらの意図と違う事を同一branchでやってしまいました。

Copy link
Member

@m-tmatma m-tmatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「sitemap.xml からダウンロードページ削除」に関係あるのならいいのですが
関係ないのなら別 PR にするのがよいと思います。

一応マージ止めておきます。

@beckorz
Copy link
Author

beckorz commented Apr 29, 2020

すみません。別の意図の物を同一branchでやってしまいました。sitemap.xmlからold_download.htmlだけ除外だけです。お手数かけます。よろしくお願いいたします。

@m-tmatma m-tmatma merged commit 811e929 into sakura-editor:develop Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants