Preserve numeric keys on #each helper#18
Merged
Conversation
Preserving keyys on #each helper, to maintain @key data variable functioning on int arrays
|
Thanks for the contribution! Before we can merge this, we need @inkarnation to sign the Salesforce.com Contributor License Agreement. |
sam-osborne
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserving numeric keys on #each helper, to maintain
@keydata variable functioning on int arraysAssuming an array should be printed out like (
enableDataVariablesset totrue):which was defined as
(key can be any integer)
The resulting
@keyvariable was always printed as0.array_slicein the helper function caused numeric keys to be set to0while maintaing string keys correctly. The pull request is enabling explicit key preserving, to fix such issue.