Present User Selected Time and Now in UTC format #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duke-harlan
reviewed
Jun 14, 2021
| @@ -532,13 +533,13 @@ $(document).ready(function() { | |||
| && ! Date.parse(sessionStorage.getItem('setSelectedEndTime')) < new Date(userDate.getTime() - 3000)){ | |||
| userDate = new Date(sessionStorage.getItem('selectedEndTime')); | |||
| } | |||
| userDate.setMinutes(now.getMinutes() - now.getTimezoneOffset()); | |||
| userDate.setMinutes(userDate.getMinutes() - userDate.getTimezoneOffset()); | |||
There was a problem hiding this comment.
does .getUTCMinutes() (as seen line 542) work here?
There was a problem hiding this comment.
Tried .getUTCMinutes() here as well but not producing the same behavior. Will talk to Sana as she was concerned with the timezone
There was a problem hiding this comment.
@duke-harlan Updated the pr to address the comment: use one technique to present both user selected time and now to local time. Please review again
duke-harlan
previously approved these changes
Jun 14, 2021
duke-harlan
previously approved these changes
Jun 15, 2021
sana-jawad
requested changes
Jun 16, 2021
sana-jawad
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement:
Currently clicking the "Now" button sends the local time now to the query, not the UTC time, since there is a time difference between local time(either in the US or in India) and UTC, if the sloop instance is not running during that time period, we will get an empty screen after clicking the 'Now' button. This is expected behavior, customer who keeps running sloop for a long time will not have this issue.
Solution:
Display both customer selected time and now in UTC format