Awaterma issue#144 property secure (#181)

awaterma · web-flow · commit dcfdd032332e · 2020-01-03T13:29:45.000-06:00
* Added unit test for issue 144; passing in master.
* Updated test to use async call and handle results correctly. Updated Dockerfile to use LTR Node v.12
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node
+FROM node:12
 MAINTAINER awaterman@salesforce.com
 LABEL Description="Vendor=\"Salesforce.com\" Version=\"1.0\""
 RUN apt-get update && \
diff --git a/test/cookie_jar_test.js b/test/cookie_jar_test.js
@@ -644,4 +644,29 @@ vows
       }
     }
   })
+  .addBatch({
+    "Issue #144 - secure": {
+      "of undefined": {
+        topic: function() {
+          const jar = new tough.CookieJar();
+          const cookieString = `AWSELB=69b2c0038b16e8e27056d1178e0d556c; 
+          Path=/, jses_WS41=5f8dc2f6-ea37-49de-8dfa-b58336c2d9ce; path=/; 
+          Secure; HttpOnly, AuthToken=EFKFFFCH@K@GHIHEJCJMMGJM>CDHDEK>CFGK?MHJ
+          >>JI@B??@CAEHBJH@H@A@GCFDLIMLJEEJEIFGALA?BIM?@G@DEDI@JE?I?HKJBIDDHJMEFEFM
+          >G@J?I??B@C>>LAH?GCGJ@FMEGHBGAF; expires=Sun, 31-Jan-9021 02:39:04 GMT; 
+          path=/; Secure; HttpOnly, FirstReferrer=; expires=Fri, 31-Jan-9020 20:50:44 
+          GMT; path=/`;
+
+          jar.setCookieSync(cookieString, "https://google.com");
+          jar.getCookies("https://google.com", this.callback)
+        },
+        "results in a 1-length array with a valid cookie": function(err, cookies) {
+          assert(!err, err);
+          assert(cookies.length == 1);
+          assert.instanceOf(cookies[0], Cookie);
+          assert.isTrue(cookies[0].secure);
+        }
+      }
+    }
+  })
   .export(module);

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM node`
	`1`	`+FROM node:12`
`2`	`2`	`MAINTAINER [email protected]`
`3`	`3`	`LABEL Description="Vendor=\"Salesforce.com\" Version=\"1.0\""`
`4`	`4`	`RUN apt-get update && \`