Awaterma issue#144 property secure #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medelibero-sfdc
approved these changes
Jan 2, 2020
There was a problem hiding this comment.
In general this looks good and is inline with the issue raised in #144. I just had a question about the dockerfile version number but that shouldn't block this PR. Thank you for doing it.
| @@ -1,4 +1,4 @@ | |||
| FROM node | |||
| FROM node:12 | |||
There was a problem hiding this comment.
Is there a reason we went with version 12 instead of latest or 13?
There was a problem hiding this comment.
13 isn't a LTS (long term supported release). Latest is a bit ephemeral; it doesn't always point to the latest build. More here: https://medium.com/@mccode/the-misunderstood-docker-tag-latest-af3babfd6375
Here's some info on Node releases and LTS: https://nodejs.org/en/about/releases/
There was a problem hiding this comment.
Ahh got it. Fair enough. I just wanted to make sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple test for issue #144 that proves it is not an issue in the codebase. Update Dockerfile to explicitly use Node 12 LTR.