fix: add types #87
fix: add types #87
Conversation
|
LGTM. I'm just curious how we can test this type def somehow? |
|
Have you considered migrating the project to typescript and generating the types export from the source? |
|
@kevinv11n done. |
| // Provides temporary backward compatibility for wire-protocol reform (lwc > 1.5.0). This code | ||
| // should be removed once all adapters are migrated to the the API. | ||
| const wireAdaptersRegistryHack = global.wireAdaptersRegistryHack || new Map(); | ||
| const wireAdaptersRegistryHack = (globalThis as any).wireAdaptersRegistryHack || new Map(); |
There was a problem hiding this comment.
This file is deprecated, so, I didn't add any types for this.
| } | ||
|
|
||
| function validateAdapterId(adapterId) { | ||
| function validateAdapterId(adapterId: any) { |
There was a problem hiding this comment.
These functions are deprecated, so I just put any everywhere.
src/__tests__/index.test.ts
Outdated
|
|
||
| it('throws error when no adapter id', () => { | ||
| expect(() => { | ||
| // @ts-ignore |
There was a problem hiding this comment.
Is this because the function is deprecated? Maybe add a comment to explain?
src/adapters/TestWireAdapter.ts
Outdated
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT | ||
| */ | ||
|
|
||
| export interface HttpFetchResponse { |
There was a problem hiding this comment.
In README there is a type/object called FetchResponse that looks bit different than here. Is it the same type or maybe we need to update README?
|
LGTM overall with only minor comments. Do you think we need to update README to include an example in TS? Also I'm curious on how did you test this on core or as a consumer of the package? |
Add Typescript definitions to the API.