Fix CI and dev envs with uv >= 0.6.0#172
Merged
Merged
Conversation
`uv<0.6` releases used `requires.txt` from `egg-info` of the sdist as a fallback. This has been changed. Since Salt requires its legacy `setup.py`, which in turn requires `setuptools<69`, it could not be built properly and its dependencies were never installed. This constrains setuptools for all package builds. In theory, we could limit this to the installation of Salt in `noxfile.py`, but the `--build-constraint` parameter requires a file, which would need to be included or created ad-hoc. Constraining setuptools in this way should not cause problems in the near future, otherwise we can go this more complicated way. I might have missed something since I'm not a Python packaging pro. Better suggestions are welcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv<0.6releases usedrequires.txtfromegg-infoof the sdist as afallback. This has been changed. Since Salt requires its legacy
setup.py, which in turn requiressetuptools<69, it could not bebuilt properly and its dependencies were never installed.
This constrains setuptools for all package builds. In theory, we
could limit this to the installation of Salt in
noxfile.py, but the--build-constraintparameter requires a file, which would need to beincluded or created ad-hoc. Constraining setuptools in this way should
not cause problems in the near future, otherwise we can go this more
complicated way. I might have missed something since I'm not a Python
packaging pro. Better suggestions are welcome.
Edit: Turns out it's not
uv's fault as evidenced bypiphaving the same problem. It's caused bysetuptools>=75.6.0. I'll quote the corresponding message on the Saltstack Discord: