Fix compound matches with nodegroups #56592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oeuftete
commented
Apr 8, 2020
|
I need to investigate why the new test fails on Windows. |
|
I need some help on how to fix the associated test here for Windows. The functionality seems to work fine on Windows minions that are targeted from the master, or if I try something like Edit: I think I sorted it out, bad quotes for Windows in the reinstated tests. |
3937da0 to
4a0db9f
Compare
dwoz
requested changes
Apr 12, 2020
4a0db9f to
94e0078
Compare
dwoz
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes compound matches with nodegroups.
What issues does this PR fix or reference?
Fixes #52678.
Tests written?
Yes, some old commented tests were restored.
Commits signed with GPG?
No