[3006.x] Do not allow duplicate message ids #65247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def7cae to
7daf0a5
Compare
ddd7b9e to
092d1ac
Compare
twangboy
approved these changes
Oct 26, 2023
s0undt3ch
reviewed
Oct 27, 2023
| super().__init__(**kwargs) | ||
| self.opts = opts | ||
| self.socket_queue = socket_queue | ||
| self._socket = None |
There was a problem hiding this comment.
Suggested change
| self._socket = None | |
| self._socket = None | |
| self.register_finalize_method(self.close) |
Comment on lines
+156
to
+158
| # pylint: disable=W1701 | ||
| def __del__(self): | ||
| self.close() |
There was a problem hiding this comment.
Suggested change
| # pylint: disable=W1701 | |
| def __del__(self): | |
| self.close() |
With the register_finalize_method change above, this is no longer necessary.
s0undt3ch
approved these changes
Oct 31, 2023
5 tasks
This was referenced Nov 29, 2023
1 task
9 tasks
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #65114
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.