Add deb822 for aptpkg #67956
Open
Add deb822 for aptpkg #67956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3786706 to
88ede53
Compare
4a2eea1 to
335b9f4
Compare
3 tasks
8bcc3d2 to
6d4e13f
Compare
twangboy
approved these changes
Jun 27, 2025
Co-authored-by: Marek Czernek <[email protected]>
Co-authored-by: Marek Czernek <[email protected]>
6d4e13f to
00c5697
Compare
|
I don't think we can bring GPL code in... |
3 tasks
|
@twangboy the copy is not exact 1:1 copy as I've removed some not required parts and aligned with the code style of salt, but the structure of the classes and the behaviour is the same. What should we do in this case? Refactor the implementation completely? It could take quite some time and could cause some misalignments with the apt implementation (which maybe not that important in such case, but from my point of view it's better to keep it aligned). I'm not deeply familiar with the licensing, but I supposed Apache-2.0 licensed projects could use GPL code as Apache-2.0 is more flexible, but I could be wrong and mixing different things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support of
deb822format toaptpkgmodule to make it working with the latest Debian based distros.IMPORTANT NOTE:It's basically the copy ofaptsourcesimplementation frompython-aptmodule which is licensed asGPL-2.0, so not sure if it's fine to copy some parts of implementation here. It's better to review if it's legally fine.This PR replaces #67748
What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/25989
Previous Behavior
aptpkgwas ignoringdeb822sources and was unable to manipulate themNew Behavior
aptpkgis able to list, modify and delete the repo sources ofdeb822format with mimicing the output to the similar to traditional to prevent rewriting the states relying on source line formatMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No