Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(debian-ip): include all mapped options as valid options #68358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3005.x
Choose a base branch
from
Open

fix(debian-ip): include all mapped options as valid options #68358

wants to merge 1 commit into from

Conversation

@perhallgren
Copy link

@perhallgren perhallgren commented Oct 1, 2025 •
edited
Loading

What does this PR do?

For debian-ip, not all options get rendered in the final interfaces file.

The valid_opts list must be a superset of the keys of the optmap map for the mappted options to get rendered.

This commit adds the missing options to the valid_opts list.

What issues does this PR fix or reference?

Fixes #58210 and #57820.

Previous Behavior

Given

    enp0sbeef:
        ----------
        network:
            |_
              ----------
              enabled:
                  True
            |_
              ----------
              type:
                  eth
            |_
              ----------
              proto:
                  static
            |_
              ----------
              ipaddr:
                  10.0.0.25/24
            |_
              ----------
              post_up_cmds:
                  - echo "hi"

/etc/network/interfaces

    auto enp0sbeef
    iface enp0sbeef inet static
        address 10.0.0.25/24

New Behavior

Given

    enp0sbeef:
        ----------
        network:
            |_
              ----------
              enabled:
                  True
            |_
              ----------
              type:
                  eth
            |_
              ----------
              proto:
                  static
            |_
              ----------
              ipaddr:
                  10.0.0.25/24
            |_
              ----------
              post_up_cmds:
                  - echo "hi"

/etc/network/interfaces

    auto enp0sbeef
    iface enp0sbeef inet static
        address 10.0.0.25/24
        post-up echo "hi"

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@welcome
Copy link

welcome bot commented Oct 1, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We're glad you've joined our community and look forward to doing awesome things with you!

@perhallgren perhallgren force-pushed the fix/3005.x/missing-debian-ip-options branch from 8bf29c7 to 5d17bd7 Compare October 1, 2025 08:27
@perhallgren
fix(debian-ip): include all mapped options as valid options
e1ab0ec 
As reported in saltstack#58210 and
saltstack#57820, not all options get rendered in
the final `interfaces` file.

The valid_opts list must be a superset of the keys of the optmap map for the
mappted options to get rendered.

This commit adds the missing options to the valid_opts list.
@perhallgren perhallgren force-pushed the fix/3005.x/missing-debian-ip-options branch from 5d17bd7 to e1ab0ec Compare October 28, 2025 10:26
@perhallgren perhallgren marked this pull request as ready for review October 28, 2025 10:29
@perhallgren perhallgren requested a review from a team as a code owner October 28, 2025 10:29
@perhallgren perhallgren requested review from twangboy and removed request for a team October 28, 2025 10:29
@perhallgren perhallgren mentioned this pull request Oct 28, 2025
Merged
3 tasks
@twangboy
Copy link
Contributor

twangboy commented Oct 31, 2025

@perhallgren We are not accepting PRs against the 3005.x branch. There will be no more releases or merge forwards from that branch. Please submit against 3006.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twangboy twangboy Awaiting requested review from twangboy twangboy is a code owner automatically assigned from saltstack/team-core

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@perhallgren @twangboy