Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Missing debian ip options #68359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2025
Merged

Missing debian ip options #68359

merged 2 commits into from
Oct 28, 2025
+59 −2

Conversation

@perhallgren
Copy link

@perhallgren perhallgren commented Oct 1, 2025

What does this PR do?

For debian-ip, not all options get rendered in the final interfaces file.

The valid_opts list must be a superset of the keys of the optmap map for the mappted options to get rendered.

This commit adds the missing options to the valid_opts list.

What issues does this PR fix or reference?

Fixes #58210 and #57820.

Previous Behavior

Given

    enp0sbeef:
        ----------
        network:
            |_
              ----------
              enabled:
                  True
            |_
              ----------
              type:
                  eth
            |_
              ----------
              proto:
                  static
            |_
              ----------
              ipaddr:
                  10.0.0.25/24
            |_
              ----------
              post_up_cmds:
                  - echo "hi"

/etc/network/interfaces

    auto enp0sbeef
    iface enp0sbeef inet static
        address 10.0.0.25/24

New Behavior

Given

    enp0sbeef:
        ----------
        network:
            |_
              ----------
              enabled:
                  True
            |_
              ----------
              type:
                  eth
            |_
              ----------
              proto:
                  static
            |_
              ----------
              ipaddr:
                  10.0.0.25/24
            |_
              ----------
              post_up_cmds:
                  - echo "hi"

/etc/network/interfaces

    auto enp0sbeef
    iface enp0sbeef inet static
        address 10.0.0.25/24
        post-up echo "hi"

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@perhallgren perhallgren marked this pull request as ready for review October 1, 2025 11:09
@perhallgren perhallgren requested a review from a team as a code owner October 1, 2025 11:09
@perhallgren perhallgren mentioned this pull request Oct 1, 2025
Open
3 tasks
twangboy
twangboy previously approved these changes Oct 1, 2025
View reviewed changes
@twangboy twangboy added the test:full Run the full test suite label Oct 1, 2025
@twangboy twangboy added this to the Sulfur v3006.17 milestone Oct 1, 2025
This was linked to issues Oct 1, 2025
[BUG] some broken options in debian_eth.jinja for /etc/network/interfaces #58210
Open
debian_ip doesn't set up_cmds #57820
Open
@perhallgren perhallgren force-pushed the fix/3006.x/missing-debian-ip-options branch from bee8a26 to 76625fc Compare October 6, 2025 04:41
@perhallgren
Copy link
Author

perhallgren commented Oct 6, 2025

twangboy the build failed due to a trailing space. I force-pushed a fix onto the previous commit. Do I need to do anything to re-run the CI?

twangboy
twangboy previously approved these changes Oct 6, 2025
View reviewed changes
@perhallgren perhallgren force-pushed the fix/3006.x/missing-debian-ip-options branch from 6fe25f1 to d108c96 Compare October 16, 2025 09:29
@perhallgren
test(debian-ip): add tests for all valid_opts
8c61b05 
Tests that all mapped options are also in valid_opts.
@perhallgren perhallgren force-pushed the fix/3006.x/missing-debian-ip-options branch from d108c96 to 8c61b05 Compare October 16, 2025 13:13
@perhallgren
Copy link
Author

perhallgren commented Oct 20, 2025

@twangboy looks lke the pipeline is pending approval to run, can you help out? :)

@perhallgren perhallgren requested a review from twangboy October 22, 2025 22:06
@dwoz dwoz merged commit dc54ee1 into saltstack:3006.x Oct 28, 2025
1335 of 1339 checks passed
@welcome
Copy link

welcome bot commented Oct 28, 2025

Congratulations on your first PR being merged! 🎉

@perhallgren
Copy link
Author

perhallgren commented Oct 28, 2025

PR for 3005: #68358
For 3007: #68436

@perhallgren perhallgren deleted the fix/3006.x/missing-debian-ip-options branch October 28, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwoz dwoz dwoz approved these changes

@twangboy twangboy Awaiting requested review from twangboy

Assignees

No one assigned

Labels

test:full Run the full test suite

Projects

None yet

Milestone

Sulfur v3006.17

Development

Successfully merging this pull request may close these issues.

[BUG] some broken options in debian_eth.jinja for /etc/network/interfaces debian_ip doesn't set up_cmds

4 participants

@perhallgren @bdrx312 @dwoz @twangboy