Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@AhmadYasser1
Copy link

@AhmadYasser1 AhmadYasser1 commented Nov 1, 2025

Backport of #68412 to 3006.x.

This PR cherry-picks the commits from the original PR and targets the oldest supported branch as requested.

Original PR: #68412

- Rename misleading variable 'typo_warning' to 'missing_vars_warning'
- Update warning message to be more accurate about missing variables
- Fix typo in warning message: 'dissolve' -> 'resolve'
- Improve code readability and maintainability

The variable name 'typo_warning' was misleading as it's actually about
missing variables in _syspaths.py, not typos. This change makes the
code more self-documenting and the warning message more helpful.
- Set sys.dont_write_bytecode = True in LazyLoaderReloadingTest.setUp()
- Restore original setting in tearDown() to avoid side effects
- Remove redundant remove_bytecode() calls in update_module() and rm_module()
- Addresses TODO comments about .pyc files being slower on reload (~3x)

This optimization prevents .pyc files from being written during test execution,
which was causing performance issues when modules were reloaded quickly.
The original TODO suggested this approach as being much faster than writing
and then removing .pyc files.
@AhmadYasser1 AhmadYasser1 requested a review from a team as a code owner November 1, 2025 22:30
@welcome
Copy link

welcome bot commented Nov 1, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We're glad you've joined our community and look forward to doing awesome things with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant