Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(preferences,repositories): fix clean parameter #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix(preferences,repositories): fix clean parameter #66

merged 1 commit into from
Sep 21, 2020

Conversation

javierbertoli
Copy link
Member

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

saltstack/salt#26605
saltstack/salt#8646

Describe the changes you're proposing

Setting the parameters to clean the `/etc/apt/{preferences,sources.list,apt.conf}.d directories,makes salt remove all the files and recreate the desired ones each time it runs:

----------
          ID: /etc/apt/preferences.d
    Function: file.directory
      Result: True
     Comment: Files cleaned from directory /etc/apt/preferences.d
     Started: 09:53:34.980124
    Duration: 8.791 ms
     Changes:   
              ----------
              /etc/apt/preferences.d/docker:
                  ----------
                  removed:
                      Removed due to clean
              /etc/apt/preferences.d/kernel-headers:
                  ----------
                  removed:
                      Removed due to clean
              /etc/apt/preferences.d/kernel-image:
                  ----------
                  removed:
                      Removed due to clean
              removed:
                  - /etc/apt/preferences.d/kernel-image
                  - /etc/apt/preferences.d/kernel-headers
                  - /etc/apt/preferences.d/docker
...
...
----------
          ID: /etc/apt/preferences.d/origin-docker
    Function: file.managed
      Result: True
     Comment: File /etc/apt/preferences.d/origin-docker updated
     Started: 09:53:35.019271
    Duration: 5.567 ms
     Changes:   
              ----------
              diff:
                  New file
              mode:
                  0644
----------
          ID: /etc/apt/preferences.d/release-kernel-image
    Function: file.managed
      Result: True
     Comment: File /etc/apt/preferences.d/release-kernel-image updated
     Started: 09:53:35.025101
    Duration: 6.085 ms
     Changes:   
              ----------
              diff:
                  New file
              mode:
                  0644
----------
          ID: /etc/apt/preferences.d/release-kernel-headers
    Function: file.managed
      Result: True
     Comment: File /etc/apt/preferences.d/release-kernel-headers updated
     Started: 09:53:35.031428
    Duration: 4.477 ms
     Changes:   
              ----------
              diff:
                  New file
              mode:
                  0644

This PR fixes this.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@javierbertoli javierbertoli requested a review from myii September 20, 2020 13:28
@pull-assistant
Copy link

pull-assistant bot commented Sep 20, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     fix(preferences,repositories): fix clean parameter

Powered by Pull Assistant. Last update 50e02fb ... 50e02fb. Read the comment docs.

@myii
Copy link
Contributor

myii commented Sep 20, 2020

@javierbertoli Can you look at the Travis failures?

@javierbertoli javierbertoli requested a review from a team as a code owner September 20, 2020 15:17
@myii myii merged commit 5c68531 into saltstack-formulas:master Sep 21, 2020
@myii
Copy link
Contributor

myii commented Sep 21, 2020

Merged, thanks @javierbertoli!

@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@robinelfrink robinelfrink mentioned this pull request Dec 17, 2022
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myii myii myii approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javierbertoli @myii @saltstack-formulas-travis