Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(readme): fix template to libvirt under bin/kitchen converge #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

docs(readme): fix template to libvirt under bin/kitchen converge #74

merged 1 commit into from
May 3, 2020

Conversation

myii
Copy link
Contributor

@myii myii commented May 3, 2020 •
edited
Loading

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@pull-assistant
Copy link

pull-assistant bot commented May 3, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     docs(readme): fix template to libvirt under bin/kitchen converge...

Powered by Pull Assistant. Last update cfde6d9 ... cfde6d9. Read the comment docs.

@myii myii marked this pull request as draft May 3, 2020 03:32
@myii myii force-pushed the docs/update-readme branch from b4e7b33 to 3f75ca7 Compare May 3, 2020 04:41
@myii myii marked this pull request as ready for review May 3, 2020 04:41
@myii myii requested a review from baby-gnu as a code owner May 3, 2020 04:41
@myii
docs(readme): fix template to libvirt under `bin/kitchen converge…
cfde6d9 
…` [skip ci]

* Add `:depth: 1` fix from `template-formula` as well
@myii myii force-pushed the docs/update-readme branch from 3f75ca7 to cfde6d9 Compare May 3, 2020 04:55
@myii
Copy link
Contributor Author

myii commented May 3, 2020 •
edited
Loading

Comment about the CODEOWNERS test performed here:

Also tested with #75 in-between and all picking up fine (for @saltstack-formulas/ssf, without pinging @baby-gnu).

@myii
Copy link
Contributor Author

myii commented May 3, 2020

Hey @baby-gnu, thanks for the review. Aren't you going to merge it? I see from the CODEOWNERS file that you're the only global owner here!!

@commit-lint
Copy link

commit-lint bot commented May 3, 2020

Documentation

  • readme: fix template to libvirt under bin/kitchen converge [skip ci] (cfde6d9)

Contributors

@myii

@baby-gnu baby-gnu merged commit 53a2afc into saltstack-formulas:master May 3, 2020
@baby-gnu
Copy link
Contributor

baby-gnu commented May 3, 2020

Hey @baby-gnu, thanks for the review. Aren't you going to merge it? I see from the CODEOWNERS file that you're the only global owner here!!

I was waiting for the tests to finish and I started something else so it took time to come back here ;-)

@myii myii deleted the docs/update-readme branch May 3, 2020 10:21
@myii
Copy link
Contributor Author

myii commented May 3, 2020

I was waiting for the tests to finish and I started something else so it took time to come back here ;-)

Actually, I saw another GitHub bot/action available for that, so that you can hit merge and it will do it automatically once the tests complete. Should we enable something like that?

@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 3.7.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@baby-gnu
Copy link
Contributor

baby-gnu commented May 3, 2020

Should we enable something like that?

So the merge is blocked by failing tests? I think it could be a good thing.

@myii
Copy link
Contributor Author

myii commented May 4, 2020

So the merge is blocked by failing tests? I think it could be a good thing.

I've collected the list of available GitHub Actions or bots:

We can go through them over time to see which ones we fancy testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baby-gnu baby-gnu baby-gnu approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myii @baby-gnu @saltstack-formulas-travis