Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci(kitchen+travis): adjust matrix to add 3000.2 & remove 2018.3 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

myii
Copy link
Contributor

@myii myii commented May 3, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii myii requested a review from a team as a code owner May 3, 2020 04:35
@pull-assistant
Copy link

pull-assistant bot commented May 3, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ci(kitchen+travis): adjust matrix to add 3000.2 & remove 2018.3

Powered by Pull Assistant. Last update 8fb7839 ... 8fb7839. Read the comment docs.

@myii myii force-pushed the ci/use-new-platforms-and-matrix branch from f563f85 to 8fb7839 Compare May 3, 2020 04:53
@myii
Copy link
Contributor Author

myii commented May 3, 2020

New matrix works across all instances except amazonlinux and arch-base:

Got closer to getting amazonlinux-2 working with this commit:

However, Python 3.7 is installed on our amazonlinux-2 instances rather than the required 3.6 (by the EPEL python libvirt package):

@myii myii merged commit f5fad10 into saltstack-formulas:master May 3, 2020
@myii myii deleted the ci/use-new-platforms-and-matrix branch May 3, 2020 05:04
@myii
Copy link
Contributor Author

myii commented May 3, 2020

Self-merge, CI changes only.

@commit-lint
Copy link

commit-lint bot commented May 3, 2020

Contributors

@myii

@saltstack-formulas-travis

🎉 This PR is included in version 3.7.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants