feat(python): define python3 package for OpenSuse Tumbleweed #83

baby-gnu · 2021-01-20T12:04:55Z

PR progress checklist (to be filled in by reviewers)

Changes to documentation are appropriate (or tick if not required)
Changes to tests are appropriate (or tick if not required)
Reviews completed

What type of PR is this?

Primary type

[build] Changes related to the build system
[chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ci] Changes to the continuous integration configuration
[feat] A new feature
[fix] A bug fix
[perf] A code change that improves performance
[refactor] A code change that neither fixes a bug nor adds a feature
[revert] A change used to revert a previous commit
[style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[docs] Documentation changes
[test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

#82

Describe the changes you're proposing

Override the python package name for openSUSE Tumbleweed-20210118.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Updated the README (e.g. Available states).
Updated pillar.example.

Testing checklist

Included in Kitchen (i.e. under state_top).
Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
Updated the relevant test pillar.

Additional context

This target architecture is not tested by Kitchen yet.

myii · 2021-01-20T12:06:19Z

@baby-gnu See #82 (comment).

aboe76

nice work @baby-gnu

myii · 2021-01-20T22:23:37Z

@baby-gnu @aboe76 I managed to build some images to test with and there's a bit more to do here to get it working with Tumbleweed fully, it seems. The good news first; in terms of this PR, python38-libvirt-python is installed successfully. However, have a failure with the very first (server) package installation.

https://gitlab.com/myii/libvirt-formula/-/pipelines/244618117

The same error for each:

Loading repository data...
Reading installed packages...
Resolving package dependencies...

Problem: libvirt-daemon-qemu-6.10.0-4.1.x86_64 requires libvirt-daemon-driver-qemu = 6.10.0-4.1, but this requirement cannot be provided
  not installable providers: libvirt-daemon-driver-qemu-6.10.0-4.1.i586[repo-oss]
                   libvirt-daemon-driver-qemu-6.10.0-4.1.x86_64[repo-oss]
 Solution 1: deinstallation of busybox-gzip-1.32.1-14.2.noarch
 Solution 2: do not install libvirt-daemon-qemu-6.10.0-4.1.x86_64
 Solution 3: break libvirt-daemon-qemu-6.10.0-4.1.x86_64 by ignoring some of its dependencies

Confirmed that locally as well.

aboe76 · 2021-01-21T20:16:01Z

@myii I don't know why busybox-gzip is a conflict for libvirt, seems strange...

baby-gnu · 2021-01-22T13:52:54Z

I managed to build some images to test with and there's a bit more to do here to get it working with Tumbleweed fully, it seems.

I made a test with your default-opensuse-tumbleweed-latest-master-py3 container, I installed gzip and removed busybox-gzip

       Summary for local
       ------------
       Succeeded: 8 (changed=4)
       Failed:    0
       ------------
       Total states run:     8
       Total run time:  40.764 s
       Downloading files from <default-opensuse-tumbleweed-latest-master-py3>
       Finished converging <default-opensuse-tumbleweed-latest-master-py3> (0m48.44s).

So, I'm wondering why the image is installed with busybox-gzip.

After that, I need to fix the tests:

  ×  Libvirt packages: verify installed packages (1 failed)
     ✔  System Package libvirt-daemon-qemu is expected to be installed
     ✔  System Package qemu-kvm is expected to be installed
     ✔  System Package libguestfs0 is expected to be installed
     ×  System Package python3-libvirt-python is expected to be installed
     expected that `System Package python3-libvirt-python` is installed
[…]
  ×  Libvirt service: verify running service (2 failed)
     ×  Service libvirtd is expected to be enabled
     expected that `Service libvirtd` is enabled
     ×  Service libvirtd is expected to be running
     expected that `Service libvirtd` is running

baby-gnu · 2021-01-25T15:11:32Z

After that, I need to fix the tests:

The inspec.platform does not seems to support the Tumbleweed OpenSuse:

inspec.platform[:name] ⮕ opensuse
inspec.platform[:family] ⮕ suse
inspec.platform[:release] ⮕ ''

We should find a way to detect this platform with the system library.

myii · 2021-01-25T15:44:35Z

We should find a way to detect this platform with the system library.

@baby-gnu There's a long story behind it, which I need to submit in a bug report to the InSpec folks. Long story short, for our use, I've chatted with @javierbertoli about something that can be done in the salt-image-builder, so there will be a resolution to this as soon as I can get those changes merged. Then those images can be used for testing here and other formulas.

@myii I don't know why busybox-gzip is a conflict for libvirt, seems strange...

@aboe76 I've also checked this and it is getting pulled in as a dependency of the systemd package:

a71f680dc614:/ # zypper install --no-recommends systemd
Retrieving repository 'openSUSE-Tumbleweed-Non-Oss' metadata .............................................................................................................[done]
Building repository 'openSUSE-Tumbleweed-Non-Oss' cache ..................................................................................................................[done]
Retrieving repository 'openSUSE-Tumbleweed-Oss' metadata .................................................................................................................[done]
Building repository 'openSUSE-Tumbleweed-Oss' cache ......................................................................................................................[done]
Retrieving repository 'openSUSE-Tumbleweed-Update' metadata ..............................................................................................................[done]
Building repository 'openSUSE-Tumbleweed-Update' cache ...................................................................................................................[done]
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following 55 NEW packages are going to be installed:
  busybox busybox-gzip chkstat dbus-1 diffutils kbd kbd-legacy kmod libapparmor1 libargon2-1 libaudit1 libblkid1 libcap-ng0 libcrypt1 libcryptsetup12 libdbus-1-3
  libdevmapper1_03 libeconf0 libexpat1 libfdisk1 libjson-c5 libkmod2 libmount1 libnsl2 libpcre2-8-0 libpkgconf3 libqrencode4 libseccomp2 libsemanage1 libsepol1 libsmartcols1
  libtirpc-netconfig libtirpc3 libutempter0 libuuid1 pam pam-config perl-base permissions permissions-config pkgconf pkgconf-m4 pkgconf-pkg-config shadow suse-module-tools
  system-group-hardware system-group-kvm systemd systemd-default-settings systemd-default-settings-branding-SLE systemd-presets-branding-MicroOS systemd-presets-common-SUSE
  sysuser-shadow udev util-linux

The following 2 packages require a system reboot:
  dbus-1 systemd

55 new packages to install.
Overall download size: 16.6 MiB. Already cached: 0 B. After the operation, additional 47.3 MiB will be used.

    Note: System reboot required.

Whereas this doesn't happen on openSUSE Leap 15.2:

8bd7cd912405:/ # zypper install --no-recommends systemd
Retrieving repository 'Non-OSS Repository' metadata ......................................................................................................................[done]
Building repository 'Non-OSS Repository' cache ...........................................................................................................................[done]
Retrieving repository 'Main Repository' metadata .........................................................................................................................[done]
Building repository 'Main Repository' cache ..............................................................................................................................[done]
Retrieving repository 'Main Update Repository' metadata ..................................................................................................................[done]
Building repository 'Main Update Repository' cache .......................................................................................................................[done]
Retrieving repository 'Update Repository (Non-Oss)' metadata .............................................................................................................[done]
Building repository 'Update Repository (Non-Oss)' cache ..................................................................................................................[done]
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following 22 NEW packages are going to be installed:
  blog dbus-1 kbd kbd-legacy kmod libapparmor1 libargon2-1 libcryptsetup12 libdbus-1-3 libdevmapper1_03 libexpat1 libjson-c3 libkmod2 libqrencode4 libseccomp2 pam-config
  pkg-config systemd systemd-presets-branding-MicroOS systemd-presets-common-SUSE sysvinit-tools udev

The following 3 packages require a system reboot:
  dbus-1 systemd udev

22 new packages to install.
Overall download size: 7.7 MiB. Already cached: 0 B. After the operation, additional 25.5 MiB will be used.

    Note: System reboot required.

We'd need to figure out what's going on there.

myii · 2021-01-25T18:30:09Z

We should find a way to detect this platform with the system library.

@baby-gnu I forgot to mention, I've got a fix for the system.rb library as well.

aboe76 · 2021-01-25T21:58:07Z

@myii could you try it with installing "busybox-static" first, before systemd.

myii · 2021-01-25T22:00:47Z

@myii could you try it with installing "busybox-static" first, before systemd.

@aboe76 It didn't make a difference:

a71f680dc614:/ # zypper install --no-recommends busybox-static
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following NEW package is going to be installed:
  busybox-static

1 new package to install.
Overall download size: 1.1 MiB. Already cached: 0 B. After the operation, additional 2.4 MiB will be used.
Continue? [y/n/v/...? shows all options] (y): 
Retrieving package busybox-static-1.32.1-1.1.x86_64                                                                                        (1/1),   1.1 MiB (  2.4 MiB unpacked)
Retrieving: busybox-static-1.32.1-1.1.x86_64.rpm .............................................................................................................[done (9.4 KiB/s)]

Checking for file conflicts: .............................................................................................................................................[done]
(1/1) Installing: busybox-static-1.32.1-1.1.x86_64 .......................................................................................................................[done]
a71f680dc614:/ # zypper install --no-recommends systemd               
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following 55 NEW packages are going to be installed:
  busybox busybox-gzip chkstat dbus-1 diffutils kbd kbd-legacy kmod libapparmor1 libargon2-1 libaudit1 libblkid1 libcap-ng0 libcrypt1 libcryptsetup12 libdbus-1-3
  libdevmapper1_03 libeconf0 libexpat1 libfdisk1 libjson-c5 libkmod2 libmount1 libnsl2 libpcre2-8-0 libpkgconf3 libqrencode4 libseccomp2 libsemanage1 libsepol1 libsmartcols1
  libtirpc-netconfig libtirpc3 libutempter0 libuuid1 pam pam-config perl-base permissions permissions-config pkgconf pkgconf-m4 pkgconf-pkg-config shadow suse-module-tools
  system-group-hardware system-group-kvm systemd systemd-default-settings systemd-default-settings-branding-SLE systemd-presets-branding-MicroOS systemd-presets-common-SUSE
  sysuser-shadow udev util-linux

The following 2 packages require a system reboot:
  dbus-1 systemd

55 new packages to install.
Overall download size: 16.6 MiB. Already cached: 0 B. After the operation, additional 47.3 MiB will be used.

    Note: System reboot required.

myii · 2021-01-25T22:02:18Z

@aboe76 To play around for yourself:

$ docker run -it --entrypoint="/bin/bash" opensuse/tumbleweed:latest

aboe76 · 2021-01-25T23:30:24Z

This is strange, I'm running an opensuse tumbleweed desktop without this busybox-gzip package installed...

baby-gnu · 2021-01-26T09:16:17Z

This is strange, I'm running an opensuse tumbleweed desktop without this busybox-gzip package installed...

It may be related to the way kiwi build the OpenSuse docker image?

aboe76 · 2021-01-26T18:42:53Z

found it, just install gzip first and then systemd.

aboe76 · 2021-01-26T18:44:13Z

busybox-gzip and the normal gzip are in conflict, gzip is a depency of libvirt-daemon-driver-qemu...it doesn't accept busybox-gzip version.

myii · 2021-01-26T19:32:33Z

found it, just install gzip first and then systemd.

@aboe76 Nice work! I'm just finishing off the merge request for the salt-image-builder, for these new Tumbleweed images. I've just tested and it's OK to install them both at the same time:

9b0d762be94f:/ # zypper install --no-recommends gzip systemd
Retrieving repository 'openSUSE-Tumbleweed-Non-Oss' metadata .............................................................................................................[done]
Building repository 'openSUSE-Tumbleweed-Non-Oss' cache ..................................................................................................................[done]
Retrieving repository 'openSUSE-Tumbleweed-Oss' metadata .................................................................................................................[done]
Building repository 'openSUSE-Tumbleweed-Oss' cache ......................................................................................................................[done]
Retrieving repository 'openSUSE-Tumbleweed-Update' metadata ..............................................................................................................[done]
Building repository 'openSUSE-Tumbleweed-Update' cache ...................................................................................................................[done]
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following 54 NEW packages are going to be installed:
  chkstat dbus-1 diffutils gzip kbd kbd-legacy kmod libapparmor1 libargon2-1 libaudit1 libblkid1 libcap-ng0 libcrypt1 libcryptsetup12 libdbus-1-3 libdevmapper1_03 libeconf0
  libexpat1 libfdisk1 libjson-c5 libkmod2 libmount1 libnsl2 libpcre2-8-0 libpkgconf3 libqrencode4 libseccomp2 libsemanage1 libsepol1 libsmartcols1 libtirpc-netconfig libtirpc3
  libutempter0 libuuid1 pam pam-config perl-base permissions permissions-config pkgconf pkgconf-m4 pkgconf-pkg-config shadow suse-module-tools system-group-hardware
  system-group-kvm systemd systemd-default-settings systemd-default-settings-branding-SLE systemd-presets-branding-MicroOS systemd-presets-common-SUSE sysuser-shadow udev
  util-linux

The following 2 packages require a system reboot:
  dbus-1 systemd

54 new packages to install.
Overall download size: 16.1 MiB. Already cached: 0 B. After the operation, additional 46.4 MiB will be used.

    Note: System reboot required.

Installing `gzip` in Tumbleweed to avoid strange packaging conflicts involving `busybox-gzip` instead, see: * saltstack-formulas/libvirt-formula#83 (comment)

baby-gnu · 2021-01-28T15:14:24Z

Hello @myii

@baby-gnu I forgot to mention, I've got a fix for the system.rb library as well.

Where can I found that fix?

myii · 2021-01-29T12:39:02Z

@baby-gnu This can be fixed and merged after #85 is merged, including enabling default-opensuse-tmbl-latest-master-py3 in both CI files (GitLab and Travis).

We need a new `map.jinja` source for the grain `oscodename`.

baby-gnu · 2021-01-30T23:34:43Z

I checked the Tumbleweed kitchen platforms on my test bed and they all work with my latest push:

~/libvirt-formula/$ ./bin/kitchen list tmbl
Instance                                 Driver  Provisioner  Verifier  Transport  Last Action  Last Error
default-opensuse-tmbl-latest-master-py3  Docker  SaltSolo     Inspec    Ssh        Verified     <None>
default-opensuse-tmbl-latest-3002-2-py3  Docker  SaltSolo     Inspec    Ssh        Verified     <None>
default-opensuse-tmbl-latest-3001-4-py3  Docker  SaltSolo     Inspec    Ssh        Verified     <None>

myii · 2021-01-31T14:06:35Z

@baby-gnu Fantastic, we got there in the end! Thanks for the review, @aboe76.

saltstack-formulas-travis · 2021-01-31T14:16:52Z

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

baby-gnu force-pushed the feature/support-opensuse-tumbleweed branch 2 times, most recently from 9c0f00d to 490593e Compare January 20, 2021 18:30

aboe76 approved these changes Jan 20, 2021

View reviewed changes

baby-gnu mentioned this pull request Jan 30, 2021

refactor(inspec): prefer shared system library to “inspec.os” #86

Merged

19 tasks

baby-gnu added 2 commits January 31, 2021 00:28

test(inspec): tumbleweed OpenSUSE use “python38-libvirt-python”

94b245f

feat(python): define python3 package for OpenSuse Tumbleweed

b6cc44c

We need a new `map.jinja` source for the grain `oscodename`.

baby-gnu force-pushed the feature/support-opensuse-tumbleweed branch from 490593e to b6cc44c Compare January 30, 2021 23:28

myii approved these changes Jan 31, 2021

View reviewed changes

myii merged commit 62f7348 into saltstack-formulas:master Jan 31, 2021

saltstack-formulas-travis added the released label Jan 31, 2021

baby-gnu mentioned this pull request Feb 1, 2021

[python] python packages for opensuse tumbleweed renamed #82

Closed

feat(python): define python3 package for OpenSuse Tumbleweed #83

feat(python): define python3 package for OpenSuse Tumbleweed #83

Uh oh!

Conversation

baby-gnu commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR progress checklist (to be filled in by reviewers)

What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

Uh oh!

myii commented Jan 20, 2021

Uh oh!

aboe76 left a comment

Choose a reason for hiding this comment

Uh oh!

myii commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aboe76 commented Jan 21, 2021

Uh oh!

baby-gnu commented Jan 22, 2021

Uh oh!

baby-gnu commented Jan 25, 2021

Uh oh!

myii commented Jan 25, 2021

Uh oh!

myii commented Jan 25, 2021

Uh oh!

aboe76 commented Jan 25, 2021

Uh oh!

myii commented Jan 25, 2021

Uh oh!

myii commented Jan 25, 2021

Uh oh!

aboe76 commented Jan 25, 2021

Uh oh!

baby-gnu commented Jan 26, 2021

Uh oh!

aboe76 commented Jan 26, 2021

Uh oh!

aboe76 commented Jan 26, 2021

Uh oh!

myii commented Jan 26, 2021

Uh oh!

baby-gnu commented Jan 28, 2021

Uh oh!

myii commented Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baby-gnu commented Jan 30, 2021

Uh oh!

myii commented Jan 31, 2021

Uh oh!

saltstack-formulas-travis commented Jan 31, 2021

Uh oh!

Uh oh!

baby-gnu commented Jan 20, 2021 •

edited

Loading

Does this PR introduce a `BREAKING CHANGE`?

myii commented Jan 20, 2021 •

edited

Loading

myii commented Jan 29, 2021 •

edited

Loading