Node.js-Week1-AmirHossein #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n4cr
requested changes
Jan 27, 2021
| @@ -0,0 +1 @@ | |||
| Welcome to server Land! | |||
There was a problem hiding this comment.
This is syntax error. It should be either a comment or a console.log
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Make sure the .vscode files are not commited. You should add .vscode to your .gitignore file.
Since these are already commited you should remove them from git using git rm .vscode first, the commit, the add it to gitignore file
|
Small changes. Looks good overall |
|
Btw now that I merged masoud PR you're getting all the conflicts |
|
Did you check the comments? and adjusted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.