Replace deprecated datetime.utcnow() in websocket_api (Python 3.12+) - #187
Open
MBK-fr wants to merge 1 commit into
Open
Replace deprecated datetime.utcnow() in websocket_api (Python 3.12+)#187MBK-fr wants to merge 1 commit into
MBK-fr wants to merge 1 commit into
Conversation
agentic/websocket_api.py uses datetime.utcnow() in five places (connection timestamps and JSON message timestamps). utcnow() is deprecated since Python 3.12 and scheduled for removal (DeprecationWarning at runtime). Replaced with datetime.now(timezone.utc).replace(tzinfo=None), which yields the exact same naive UTC value, so the stored timestamps and the .isoformat() strings sent over the websocket are byte-for-byte identical. timezone is added to the existing datetime import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agentic/websocket_api.pyusesdatetime.utcnow()in five places (connectionconnected_at/last_pingand JSON messagetimestampfields).Why
utcnow()is deprecated since Python 3.12 and scheduled for removal, so it emits aDeprecationWarningat runtime.Fix
Replaced with
datetime.now(timezone.utc).replace(tzinfo=None), which produces the exact same naive UTC datetime. The stored timestamps and the.isoformat()strings sent over the websocket are therefore byte for byte identical (no+00:00suffix is introduced).timezoneis added to the existingfrom datetime import datetimeimport.The already-guarded site in
scanners/github_secret_hunt/github_secret_hunt.py(which intentionally selectsutcnow()vsnow(timezone.utc)based on tzinfo) is left untouched. Compiles clean.