Add mypy typings to project compatible with python 3.10 + run unit tests in CI#15
Open
jacobdr wants to merge 6 commits intosamwillis:mainfrom
Open
Add mypy typings to project compatible with python 3.10 + run unit tests in CI#15jacobdr wants to merge 6 commits intosamwillis:mainfrom
jacobdr wants to merge 6 commits intosamwillis:mainfrom
Conversation
…atest 0.38.2 release
Owner
|
Happy to be tied to 3.10 for now and add these typings. All looks good, once the conflicts are fixed will merge. |
Owner
|
We should update 'DEVELOPMENT.md' to note the minimum python version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
mypytype checking to all of our internal code -- whereas #8 added typing for our external codeI used pretty modern type syntax, therefore this PR now requires project developers (and our release machinery) to use Python 3.10 specifically (though really we could support 3.10+, I wanted to KISS for now)