forked from JodaOrg/joda-time-jsptags
-
Notifications
You must be signed in to change notification settings - Fork 10
Issue/10 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Issue/10 #11
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bbb481b
Connect to eclipse and fix some classpath issues for updates
jpschewe b3f8571
Got everything building
jpschewe 747972e
Migrate to jakarta package names
jpschewe 23876c0
Gradle 7.3.3
jpschewe b11d465
Move test classes into package
jpschewe e3a9df2
Fix localTimeTest
jpschewe 4df667b
Fix year test
jpschewe b6b454d
Fix offsetTimeTest
jpschewe 8f9c00f
Fix a number of tests
jpschewe 48413ea
Rework how day of week is tested
jpschewe 1a71d1c
Don't need the special testCompile configuration
jpschewe 836ebe0
Increment version to 2.0.0
jpschewe 5daf5e1
Cleanup
jpschewe 224701a
Remove IDE files
jpschewe df014ec
Remove eclipse integration
jpschewe 48949c9
Merge remote-tracking branch 'origin/master' into issue/10
jpschewe 101a913
Revert formatting changes
jpschewe 1e0faa5
Reverted more formatting
jpschewe 19f2424
Add missing newline at EOF
jpschewe f85d1ae
More reverting of formatting.
jpschewe a6fb112
Remove local maven repository
jpschewe f189aa7
Revert changes to calling super.release
jpschewe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,38 @@ | ||
| plugins { | ||
| id "com.jfrog.bintray" version "1.7.3" | ||
| id "java" | ||
| id "maven-publish" | ||
| } | ||
|
|
||
| apply plugin: 'java' | ||
| apply plugin: 'maven' | ||
|
|
||
| group = 'net.sargue' | ||
| archivesBaseName = 'java-time-jsptags' | ||
| version = '1.1.4' | ||
| version = '2.0.0' | ||
|
|
||
| sourceCompatibility = 1.8 | ||
| compileJava.options.encoding = 'UTF-8' | ||
| compileTestJava.options.encoding = 'UTF-8' | ||
|
|
||
| repositories { | ||
| jcenter() | ||
| java { | ||
| // set version of Java that the source confirms to. | ||
| // The bytecode will be for this version of Java as well, unless targetCompatibility is specified. | ||
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| } | ||
|
|
||
| configurations { | ||
| testCompile.extendsFrom compileOnly | ||
| repositories { | ||
| mavenCentral() | ||
| // for snapshot release of spring that includes jakarta classes | ||
| maven { | ||
| url "https://repo.spring.io/milestone" | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| compileOnly 'javax.servlet:javax.servlet-api:3.0.1' | ||
| compileOnly 'javax.servlet.jsp:javax.servlet.jsp-api:2.2.1' | ||
| compileOnly 'javax.servlet.jsp.jstl:javax.servlet.jsp.jstl-api:1.2.1' | ||
| implementation(group: "jakarta.servlet", name: "jakarta.servlet-api", version: "5.0.0") | ||
| implementation(group: "jakarta.servlet.jsp", name: "jakarta.servlet.jsp-api", version: "3.0.0") | ||
| implementation(group: "jakarta.servlet.jsp.jstl", name: "jakarta.servlet.jsp.jstl-api", version: "2.0.0") | ||
sargue marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| testCompile 'junit:junit:4.12' | ||
| testCompile 'org.springframework:spring-test:4.1.7.RELEASE' | ||
| testImplementation(group: "junit", name: "junit", version: "4.12") | ||
| testImplementation(group: "org.springframework", name: "spring-test", version: "6.0.0-M2") | ||
| } | ||
|
|
||
| jar { | ||
|
|
@@ -51,36 +56,36 @@ artifacts { | |
| archives javadocJar, sourcesJar | ||
| } | ||
|
|
||
| install { | ||
| repositories.mavenInstaller { | ||
| pom.project { | ||
| name 'Java 8 java.time JSP tags' | ||
| description 'JSP tag support for Java 8 java.time (JSR-310)' | ||
| url 'https://github.com/sargue/java-time-jsptags' | ||
|
|
||
| scm { | ||
| connection 'scm:git:[email protected]:sargue/java-time-jsptags.git' | ||
| developerConnection 'scm:git:[email protected]:sargue/java-time-jsptags.git' | ||
| url '[email protected]:sargue/java-time-jsptags.git' | ||
| } | ||
|
|
||
| licenses { | ||
| license { | ||
| name 'The Apache License, Version 2.0' | ||
| url 'http://www.apache.org/licenses/LICENSE-2.0.txt' | ||
| } | ||
| } | ||
|
|
||
| developers { | ||
| developer { | ||
| id 'sargue' | ||
| name 'Sergi Baila' | ||
| email '[email protected]' | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| // install { | ||
| // repositories.mavenInstaller { | ||
| // pom.project { | ||
| // name 'Java 8 java.time JSP tags' | ||
| // description 'JSP tag support for Java 8 java.time (JSR-310)' | ||
| // url 'https://github.com/sargue/java-time-jsptags' | ||
| // | ||
| // scm { | ||
| // connection 'scm:git:[email protected]:sargue/java-time-jsptags.git' | ||
| // developerConnection 'scm:git:[email protected]:sargue/java-time-jsptags.git' | ||
| // url '[email protected]:sargue/java-time-jsptags.git' | ||
| // } | ||
| // | ||
| // licenses { | ||
| // license { | ||
| // name 'The Apache License, Version 2.0' | ||
| // url 'http://www.apache.org/licenses/LICENSE-2.0.txt' | ||
| // } | ||
| // } | ||
| // | ||
| // developers { | ||
| // developer { | ||
| // id 'sargue' | ||
| // name 'Sergi Baila' | ||
| // email '[email protected]' | ||
| // } | ||
| // } | ||
| // } | ||
| // } | ||
| // } | ||
|
|
||
| bintray { | ||
| user = project.hasProperty('BINTRAY_USER') ? BINTRAY_USER : '' | ||
|
|
||
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| #Fri Jan 21 21:48:13 CST 2022 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-bin.zip |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.