Add support for first-class calc() #1452
Conversation
|
This shouldn't be submitted until we've also got an approved PR adding documentation for it to the Sass website. |
| /// The definitions of Sass introspection functions that are only available from | ||
| /// the `sass:meta` module, not as global functions. | ||
| final local = UnmodifiableListView([ | ||
| _function("calc-name", r"$calc", (arguments) { |
There was a problem hiding this comment.
should it calc-name or calculation-name as the value type has been changed to calculation to avoid confusion with the fact that not all calculations are for calc() ?
There was a problem hiding this comment.
That's something we probably should have talked through in the design process 😅. I think it's fine though to keep this name short, since "calc" can also be read as short for "calculation".
There was a problem hiding this comment.
That's something we probably should have talked through in the design process
I agree. But that's something I missed when re-reading the proposal after the renaming of the type from calc to calculation. It is still better to discuss that now than after landing the feature in a release.
See sass/sass#818
See sass/sass-spec#1688