Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Upgrade to libsass==3.1.0. Resolves #36. Resolves #38. #43

Merged
dahlia merged 2 commits into from
Feb 1, 2015
Merged

Upgrade to libsass==3.1.0. Resolves #36. Resolves #38. #43

dahlia merged 2 commits into from
Feb 1, 2015

Conversation

@asottile
Copy link
Member

@asottile asottile commented Jan 30, 2015

Things this does:

This is a prerequisite to implementing #13

@asottile
Copy link
Member Author

asottile commented Jan 30, 2015

oops, forgot to run the py3 tests, one sec lemme fixup my test

@coveralls
Copy link

coveralls commented Jan 30, 2015

Coverage Status

Coverage increased (+1.96%) to 72.04% when pulling 0259a57 on asottile:upgrade_to_cpp_api into 0cb44c3 on dahlia:python.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 30, 2015

Coverage Status

Coverage increased (+1.96%) to 72.04% when pulling 0259a57 on asottile:upgrade_to_cpp_api into 0cb44c3 on dahlia:python.

@coveralls
Copy link

coveralls commented Jan 30, 2015

Coverage Status

Coverage increased (+2.91%) to 72.99% when pulling 15df8fc on asottile:upgrade_to_cpp_api into 0cb44c3 on dahlia:python.

@dahlia
Copy link
Member

dahlia commented Jan 31, 2015

Now does it become to have to write @charset "UTF-8"; in order to use non-ASCII characters?

@dahlia
Copy link
Member

dahlia commented Jan 31, 2015

Anyway, huge thanks for your effort!

@asottile
Copy link
Member Author

asottile commented Jan 31, 2015

This seems to be the PR which fixes the bug of not having @charset: sass/libsass#717

@dahlia
Copy link
Member

dahlia commented Feb 1, 2015

Okay, I will consider whether cherry-pick sass/libsass#717 or not, after merging this PR.

dahlia added a commit that referenced this pull request Feb 1, 2015
@dahlia
Merge pull request #43 from asottile/upgrade_to_cpp_api
b043a03 
Upgrade to libsass==3.1.0.  Resolves #36.  Resolves #38.
@dahlia dahlia merged commit b043a03 into sass:python Feb 1, 2015
@asottile
Copy link
Member Author

asottile commented Feb 1, 2015

Here's my thoughts (I think you should keep it):

  1. Currently we're pointing at vanilla 3.1.0. Picking patches out of that would mean we don't support the same feature set as 3.1.0 (and we'd stop being a simple wrapper).
  2. Precedence:
    • npm node-sass: has @charset for files containing non-ASCII bytes
    • ruby-gem sass: has @charset for files containing non-ASCII bytes
  3. This spec-set: https://github.com/sass/sass-spec/blob/master/spec/basic/45_str_insert/input.scss https://github.com/sass/sass-spec/blob/master/spec/basic/45_str_insert/expected_output.css

@asottile asottile deleted the upgrade_to_cpp_api branch February 1, 2015 16:21
dahlia added a commit that referenced this pull request Mar 4, 2015
@dahlia
Changelog for #43 and #44
6d156ae
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asottile @coveralls @dahlia