Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

johntiger1
Copy link
Contributor

I am not sure if the code currently has this functionality, but I think others might appreciate an option to ignore obsolete terms. For example, in my research, I choose to ignore obsolete terms because they are unnecessary. (The way I currently do this is a hacky and inefficient way where I loop through the term map and manually remove if it is obsolete).

Also, this is only a suggestion, since I feel like we can ignore obsoletes at a lower level (i.e. at the file stream level) and save some time there.

@sba1
Copy link
Owner

sba1 commented Jul 31, 2017

Thanks a lot for your patch. Please note that the core of the ontologizer (including the io stuff) has been moved to a dedicated project that you can find at https://github.com/ontologizer/ontologizerlib. While the original Ontologizer does not take advantage of it, it certainly will do at some time in the future. I suggest therefore to write against that project.

I also suggest creating a new flag similar to the other settings of the parser (e.g., PARSE_OBSOLETES or something like this) instead of relying on inheritance.

As a side note, it may be important to know also obsolete terms because an older annotation file may still refer to an now-obsolete term. While such annotations cannot be used, this information can be used to produce a particular warning, e.g., one may suggest to try a newer annotation file. Therefore the feature should be optional (as you have implemented it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants