Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cpp20#2

Open
sbstndb wants to merge 9 commits into
masterfrom
cpp20
Open

cpp20#2
sbstndb wants to merge 9 commits into
masterfrom
cpp20

Conversation

@sbstndb

@sbstndb sbstndb commented Apr 4, 2025

Copy link
Copy Markdown
Owner

For CI.

sbstndb and others added 9 commits April 3, 2025 10:45
	-	Previously, we had the option of activating c++20.
	-	But as we defined c++20 as default, I suggest to replace
			this option as c++23.
	-	Previously, tests was in c++17
	-	We want to add c++20 by default, so I modify the test cmake
	-	The tests passed locally
	-	Previously, The MSVC version was not well recognized
		--> Hence, there was some bugy macro specific to MSVC/c++20
	-	This Commit resolve the issue and I am now able to
			compile the problematic testcase
	-	Question : SHould we add this flag not at the tets level
			but at the main CMakeFiles level ?
	-	Previously, on MSVC, in c++20, the empty() function was incorrectly deduced
	-	Hence the test_xbuilder no longer pass
	-	I suggest enforce the right specialization by specifying the last template parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant