Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Small cheatsheet fixes #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 31, 2019
Merged

Small cheatsheet fixes #1461

merged 18 commits into from
Jul 31, 2019

Conversation

toy
Copy link
Contributor

@toy toy commented Jul 24, 2019

A lot of added and removed whitespace, added dots, capitalisation + few slightly changed and one fixed example.

@ashawley
Copy link
Member

Thanks for doing this. I fixed a lot of formatting in #1280, but knew it still needed more work.

ashawley
ashawley reviewed Jul 25, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 25, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 25, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 25, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 25, 2019
View reviewed changes
@toy
Copy link
Contributor Author

toy commented Jul 25, 2019

@ashawley Please have a look once more
Seems I can't re-request review :)

ashawley
ashawley reviewed Jul 26, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 26, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 26, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 26, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 26, 2019
View reviewed changes
ashawley
ashawley reviewed Jul 26, 2019
View reviewed changes
julienrf
julienrf reviewed Jul 29, 2019
View reviewed changes
@toy
Copy link
Contributor Author

toy commented Jul 29, 2019

@ashawley @julienrf Please have a look once more

@ashawley
Copy link
Member

Looks good to me. Thanks again for doing this.

@SethTisue
Copy link
Member

needs rebase

@toy toy force-pushed the small-cheatsheet-fixes branch from 95a5f41 to f1da6cd Compare July 30, 2019 23:08
@toy
Copy link
Contributor Author

toy commented Jul 30, 2019

@SethTisue Done

@SethTisue SethTisue merged commit 3bbc21b into scala:master Jul 31, 2019
@SethTisue
Copy link
Member

awesome, thanks for this!

@toy toy deleted the small-cheatsheet-fixes branch July 31, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf left review comments

+1 more reviewer

@ashawley ashawley ashawley left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toy @ashawley @SethTisue @julienrf