Tour: "Singleton Objects" #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I don't agree with this last sentence; it seems incorrect and misleading to me to call something a "companion object" unless it actually is one. Let's not encourage this.
There was a problem hiding this comment.
@SethTisue I agree.
|
LGTM except for the one piece of feedback. @S11001001 if you agree and correct it, I'll merge. |
|
Thanks for the review @SethTisue! I'm going to pull this in and add a follow-up commit where I remove the last contentious sentence. That way this is in the docs without any further delay :) |
heathermiller
added a commit
that referenced
this pull request
Jul 14, 2015
Tour: "Singleton Objects"
heathermiller
added a commit
that referenced
this pull request
Jul 14, 2015
|
@SethTisue @heathermiller Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With links from other tour parts.
This is incompatible with #307, but can be renumbered with its script straightforwardly.