-
Notifications
You must be signed in to change notification settings - Fork 1k
fix: fix errors and typos #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution. While I can't really comment on the Chinese fixes, "hash trie" in the English documentation is correct. Our HashMaps are backed by an efficient trie implementation... Could you drop the commits that rename Hash Tries? I assume the Chinese bits are correct :) |
@hepin1989 interested in helping review Chinese-language PRs like these? or know anybody who is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not change
I have to say ,this translation is more like translated by mechine not by a human. @SethTisue I have to say ,this translation is far form it's quality. |
I really don't know there is a Chinese translation,but I have to say ,thr current translation is not that good,and have some wrong translated.I want to improve that ,but just hard to find time. |
we'd certainly welcome additional fixes. every little bit helps. |
Given that both the Chinese and English improvements have issues, @SethTisue do you advise that we close? Or give @apapi a chance to remedy these issues? |
let's wait for @apapi. also, I think @hepin1989's comments about the overall quality are about the translation as a whole, rather than about the quality of @apapi's edits to that translation. we could still accept @apapi's edits (if revised to reflect the feedback so far) as long as they are some kind of improvement. |
@heathermiller thank you for educating me on HashMap implementation. |
thanks all! |
No description provided.