Allow eta-expansion of methods with dependent types #10166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
reviewed
Sep 27, 2022
som-snytt
reviewed
Sep 27, 2022
| } | ||
| val expansion = etaExpand(tree, context.owner) | ||
| if (context.undetparams.isEmpty) typed(expansion, mode, pt) | ||
| else instantiate(typed(expansion, mode), mode, pt) |
There was a problem hiding this comment.
I don't understand the restriction yet, but etaExpand still has adriaanm comment that not supported.
There was a problem hiding this comment.
Thanks! I'll be off for a week 🇷🇴 and don't have more time right now to try to break it, will get back to it after.
There was a problem hiding this comment.
Enjoy! Insert joke about children as dependent types.
There was a problem hiding this comment.
Added a few more tests, AFAICT etaExpand works well with dependent method types
|
@som-snytt care to give this a second round of review? |
Merged
som-snytt
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12641