Do not embed absolute path into class files when -Xcheckinit flag is used #10237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
LGTM, thank you!
The change doesn't reflect in the existing tests because our test tool (partest) strips off file paths from test output, so the check file already has the right format (https://github.com/scala/scala/blob/2.13.x/test/files/run/checkinit.check).
Running the test manually shows the difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12698
It changes the code emitted when
-Xcheckinitflag is used. The result of this fix will be that instead of emitting something like this:The following code will be emitted:
This will make sure that the classes do not contain absolute path embedded into them anymore.
It will allow to build such objects on another machine, with different directory structure, without changing the resulting artifact.
The potential issues
Possible alternatives
It might be possible to introduce the flag changing the behavior and, potentially, controlling other places if such issue to occur in these places. I.e.
-Xreproducibleor-Xstripabsolutepaths, or something like that.Also see scala/scala-dev#405 for more discussion on why having reproducible builds is good.