Minor refactor in ListSet to foreground guards and add test #10248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
approved these changes
Dec 23, 2022
| @@ -691,7 +691,7 @@ lazy val junit = project.in(file("test") / "junit") | |||
| (Test / forkOptions) := (Test / forkOptions).value.withWorkingDirectory((ThisBuild / baseDirectory).value), | |||
| (Test / testOnly / forkOptions) := (Test / testOnly / forkOptions).value.withWorkingDirectory((ThisBuild / baseDirectory).value), | |||
| libraryDependencies ++= Seq(junitDep, junitInterfaceDep, jolDep), | |||
| testOptions += Tests.Argument(TestFrameworks.JUnit, "-a", "-v"), | |||
| testOptions += Tests.Argument(TestFrameworks.JUnit, "-a", "-v", "-s"), | |||
There was a problem hiding this comment.
|
fyi @scala/collections |
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
Minor refactor in ListSet to foreground guards and add test
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
Minor refactor in ListSet to foreground guards and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fine to use
isEmptyas its implementation is trivial.Avoided whitespace change (of the big code block which could be shifted left). (It looks nice refactored to a function so the case statements line up; maybe someone's editor collapses case bodies?)