Unused warnings: for macros, by default, look for usages in expansion#10693
Merged
Merged
Conversation
c2a6c08 to
4a77a23
Compare
Contributor
Author
|
The missing interpolator lint should be in refchecks. The new motivation is that it only warns when the literal is typechecked, not after macro expansion. Since refchecks can check the expandee, it can warn more consistently. |
4a77a23 to
b638a21
Compare
lrytz
approved these changes
Mar 5, 2024
Member
|
@som-snytt (now that we have an approval from Lukas, let's turn to the matter of documentation) is there migration advice that could be in the PR description? as in, I am a Scala user, what do I do now? |
Contributor
Author
That is what everyone is asking themselves. Let me know the results of the next community build. |
Contributor
Author
|
I wonder if this PR ever saw that community build. I updated the description to include the "missing interpolator" lint seen by some users of assert macros. |
This was referenced Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
-Wunusedcan be satisfied by a usage introduced by a macro expansion.This is the revised behavior under
-Wmacros:default. Previously, the default setting was-Wmacros:before, to lint only before any macros are expanded. The new behavior may reduce the need to suppress warnings.Previously,
-Wmacros:aftercould be used to lint only the expansion, but if the expansion introduces more unused definitions, then those will generate warnings under that mode.Note that linting the macro expansion will also warn for
-Xlint:missing-interpolator, since 2.13.14. Macros for test assertions that capture interpolations as regular string literals will warn. For example, if a macro transformsinto
Fixes scala/bug#12953