Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix LazyList.range [ci: last-only] #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BalmungSan wants to merge 8 commits into
base: 2.13.x
Choose a base branch
from
Open

Fix LazyList.range [ci: last-only] #10767

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6de2bf8
Override LazyList.range
BalmungSan Apr 30, 2024
91088b5
Test LazyList.range
BalmungSan Apr 30, 2024
bd3db0d
Better LazyList.range impl
BalmungSan Apr 30, 2024
f7745a4
Move LazyList.range implementation closer to other overrides
BalmungSan Apr 30, 2024
2028dae
Ensure lazyness of `Integral[A].one` for overrided `range` implementa…
BalmungSan Apr 30, 2024
fbc2623
Ensure step can't be zero
BalmungSan Apr 30, 2024
1ac4f64
Allow reverse LazyList.range
BalmungSan Apr 30, 2024
b4eb90a
Make the lazyRangeAllowsMoreThanIntMaxValue test run fast
BalmungSan Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow reverse LazyList.range
  • Loading branch information
@BalmungSan
BalmungSan committed Apr 30, 2024
commit 1ac4f643c3f27d3d6b6b322d2afeccf4fb691b57
10 changes: 6 additions & 4 deletions src/library/scala/collection/immutable/LazyList.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,17 +1231,19 @@ object LazyList extends SeqFactory[LazyList] {
}

override def range[A: Integral](start: A, end: A): LazyList[A] =
newLL(rangeImpl(start, end, step = Integral[A].one))
newLL(rangeImpl(start, end, step = Integral[A].one, sign = true))

override def range[A](start: A, end: A, step: A)(implicit ev: Integral[A]): LazyList[A] =
newLL {
if (ev.equiv(step, ev.zero)) throw new IllegalArgumentException("step cannot be 0.")
else rangeImpl(start, end, step)
else rangeImpl(start, end, step, sign = ev.sign(step) == ev.one)
}

private[this] def rangeImpl[A](start: A, end: A, step: A)(implicit ev: Integral[A]): State[A] =
if (ev.lt(start, end)) sCons(start, newLL(rangeImpl(ev.plus(start, step), end, step)))
private[this] def rangeImpl[A](start: A, end: A, step: A, sign: Boolean)(implicit ev: Integral[A]): State[A] = {
val check = if (sign) ev.lt(start, end) else ev.gt(start, end)
if (check) sCons(start, newLL(rangeImpl(ev.plus(start, step), end, step, sign)))
else State.Empty
}

// significantly simpler than the iterator returned by Iterator.unfold
override def unfold[A, S](init: S)(f: S => Option[(A, S)]): LazyList[A] =
Expand Down